Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improvements in offer list payments filter #2691

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Further improvements in offer list payments filter #2691

merged 5 commits into from
Aug 26, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Aug 25, 2024

Towards #2667

  • Add new DropdownMenuItem decoupled from BisqMenuItem for greater flexibility.
  • Show payment methods icons.
  • Add highlight to the menu when filter is active.

@axpoems axpoems force-pushed the further-imp-payment-filter branch from 6d4f668 to 8b9327e Compare August 25, 2024 17:35
HenrikJannsen
HenrikJannsen approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen merged commit 402543c into bisq-network:main Aug 26, 2024
18 of 21 checks passed
@axpoems axpoems deleted the further-imp-payment-filter branch August 26, 2024 16:14
@axpoems axpoems mentioned this pull request Sep 10, 2024
Open
@HenrikJannsen HenrikJannsen added this to the 2.1.2 milestone Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@axpoems @HenrikJannsen