Improve material text field validation #1991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulated automatically for error text
resize of component when error is shown. Also bring back helptext when error disappears changed helpLabel code to errorLabel code for error validation made helplabel invisible when error label shows removed commented code. Setting errorlabel to help is unecessary changed spacing of vbox to accomodate error message removed setopacity and used setmanage instead. Made height to be calculated automatically for error text removed unecessary commented code enabled reformat code added code to make height go back to original position after resize Check that error style does not exist before you set error style
…lTextField-and-not-reuse-helpLabel-as-it-would-cause-an-exception-when-binding-at-the-helpLabel-is-used-#1783' into Add-custom-errorLabel-to-MaterialTextField-and-not-reuse-helpLabel-as-it-would-cause-an-exception-when-binding-at-the-helpLabel-is-used-bisq-network#1783 # Conflicts: # apps/desktop/desktop/src/main/java/bisq/desktop/components/controls/MaterialTextField.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1901 (review)