Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alert banner paddings #1937

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Fix alert banner paddings #1937

merged 10 commits into from
Mar 27, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Mar 26, 2024

  • Move alert notification management to a separate service.
  • Fix paddings when showing an alert banner (both in the general case and when colliding with another Bisq Easy notification).

not-paddings

@axpoems axpoems added the ui label Mar 26, 2024
@HenrikJannsen
Copy link
Contributor

HenrikJannsen commented Mar 27, 2024 •
edited
Loading

If both orange based panes are displayed the small difference in both looks weird. Maybe better use the same color. With the icon and headline it distinguishes sufficiently from notifications.
Maybe also make text colors same?

Screenshot 2024-03-27 at 09 40 49

@axpoems
Copy link
Contributor Author

axpoems commented Mar 27, 2024 •
edited
Loading

If both orange based panes are displayed the small difference in both looks weird. Maybe better use the same color. With the icon and headline it distinguishes sufficiently from notifications.
Maybe also make text colors same?

This PR fixes the paddings. The colours can be addressed in another PR. The Bisq Easy notification will be revised accordingly.

HenrikJannsen
HenrikJannsen approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@djing-chan djing-chan merged commit 5dac806 into bisq-network:main Mar 27, 2024
16 checks passed
@axpoems axpoems deleted the alert-improvements branch March 27, 2024 17:15
@axpoems axpoems mentioned this pull request Mar 29, 2024
Closed
@djing-chan djing-chan added this to the 2.0.3 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@axpoems @HenrikJannsen @djing-chan