Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve style of matching offers table in trade wizard #1868

Merged
merged 6 commits into from
Mar 23, 2024
Merged

Improve style of matching offers table in trade wizard #1868

merged 6 commits into from
Mar 23, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Mar 18, 2024

Resolves #1833

  • Change matching offers table styles to match the standard style of tables used in the app.
  • Add selection marker column.
  • Remove unnecessary and confusing column used to select offer.
  • Minor refactors.

table-imp

@axpoems axpoems added the ui label Mar 18, 2024
@axpoems axpoems changed the title Improve style of matching offers in trade wizard Improve style of matching offers table in trade wizard Mar 18, 2024
HenrikJannsen
HenrikJannsen approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen added this to the 2.0.2 milestone Mar 21, 2024
alvasw
alvasw approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit a386acf into bisq-network:main Mar 23, 2024
16 checks passed
@axpoems axpoems deleted the improve-matching-offers-table branch March 23, 2024 17:21
@axpoems axpoems mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

@alvasw alvasw alvasw approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

Improve style of matching offers in trade wizard
3 participants
@axpoems @alvasw @HenrikJannsen