Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and update take-offer status feedback overlay #1846

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Review and update take-offer status feedback overlay #1846

merged 2 commits into from
Mar 18, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Mar 17, 2024

Based on #1832

  • Use as waiting icon the Bisq Easy logo.
  • Show take-offer state for at least 8 seconds (less than that the user is not able to read and looks confusing).
  • Unify overlays so that we don't see interruption between them.

take-offer-fb

I will follow-up with some improvements.

@axpoems axpoems added the ui label Mar 17, 2024
@axpoems axpoems mentioned this pull request Mar 17, 2024
Merged
HenrikJannsen
HenrikJannsen approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

alvasw
alvasw approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #1846 (review)

@alvasw alvasw merged commit 89d1f22 into bisq-network:main Mar 18, 2024
16 checks passed
@axpoems axpoems deleted the improve-take-offer-overlay branch March 18, 2024 16:22
@HenrikJannsen HenrikJannsen added this to the 2.0.2 milestone Mar 19, 2024
@axpoems axpoems mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

@alvasw alvasw alvasw approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@axpoems @alvasw @HenrikJannsen