Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favourites system to offerbook markets #1817

Merged
merged 18 commits into from
Mar 17, 2024
Merged

Add favourites system to offerbook markets #1817

merged 18 commits into from
Mar 17, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Mar 16, 2024

Based on #1816

  • Add capability to store favourite markets in user settings.
  • Use market favourites in offerbook as a way to pin markets.
  • Introduce new icons dedicated to favourites.

image

Will follow-up with remaining improvements on this.

axpoems added 18 commits March 16, 2024 10:31
@axpoems
Fix market logo effect not matching selected row
9bb9fd2 
Resolve bisq-network#1802
@axpoems
Remove inefficent way of tracking selected market item
f112b82
@axpoems
use toString method instead of getMarketString
00b201f
@axpoems
Remove unnecessary resetting effect
383ca45
@axpoems
Move responsability of setting market logo effect to market item
887779a
@axpoems
Only handle unsubscribe when cleaning previous row
4a859b5
@axpoems
Keep market item selected while and after using search
da466a8
@axpoems
Add FavouriteMarkets into SettingsStore
93c6140 
* Store a set of markets into SettingsStore to save favourites.
* Create a convenience service class to operate with favourites.
@axpoems
Make favouriteMarkets available from the BisqEasy Offerbook model
3604b6f
@axpoems
Filter favourite markets from markets table view
7a25067
@axpoems
Add favourites list into the market selector column
3aa0ea9
@axpoems
Fix conflicts after rebasing
bd324aa
@axpoems
Improve market favourites list styles
8179ebb
@axpoems
Add functionality to add/remove markets
bcb5993
@axpoems
Fix selected market channel
322eec5
@axpoems
Refactor: rename css class for specific market selection lists
82ece3a
@axpoems
Fix selected market channel item when adding/removing favourites
d946e2e
@axpoems
Add new favourite icons
6408d04
HenrikJannsen
HenrikJannsen approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen added this to the 2.0.2 milestone Mar 17, 2024
@HenrikJannsen HenrikJannsen added feature New feature or request ui labels Mar 17, 2024
alvasw
alvasw approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 9969f21 into bisq-network:main Mar 17, 2024
16 checks passed
@axpoems axpoems deleted the add-favourites branch March 23, 2024 17:22
@axpoems axpoems mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

@alvasw alvasw alvasw approved these changes

Assignees
No one assigned
Labels
feature New feature or request ui
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@axpoems @alvasw @HenrikJannsen