Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filtered markets on new offers #1738

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

DrColver
Copy link
Contributor

@DrColver DrColver commented Mar 4, 2024

To immediately show markets with new offers that previously had no offers the filtered markets need to be updated when new offers appear.

The most obvious use case is to allow a user that creates the first offer for a market to see the market pop up in the filtered list.

DrColver added 2 commits March 4, 2024 17:51
To immediately show markets with new offers that previously had no
offers the filtered markets need to be updated when new offers appear.

The most obvious use case is to allow a user that creates the first
offer for a market to see the market pop up in the filtered list.
Copy link
Contributor

@axpoems axpoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Added one comment.

Copy link
Contributor

@axpoems axpoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw
Copy link
Contributor

alvasw commented Mar 8, 2024

This PR has conflicts that must be resolved.

Conflicting files:
apps/desktop/desktop/src/main/java/bisq/desktop/main/content/bisq_easy/offerbook/BisqEasyOfferbookModel.java

@DrColver
Copy link
Contributor Author

DrColver commented Mar 9, 2024

@alvasw conflict resolved

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 923f617 into bisq-network:main Mar 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants