-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify chat window headers for public channels #1539
Conversation
Looks good to me. Was the change of the green color in the main path buttons at dashboard and bisq easy welcome screen intended? For the common chats header I think it would be better to move the icon from the tab to the header and make maybe the header text the same style as in offerbook. For the create offer button a bigger text would give it more weight and we could consider to add an icon. Maybe to move the 2 icons left to the search box would make the search box more aligned with the right side. Alternatively maybe we could find other icons which would fit better to the search box style. |
No, this is a regression. Thanks for pointing it out. I will fix this now.
I agree. I will add the icons with the PR where I make the improvements in the icons.
I will review all the text sizes in general so for the moment, some things will appear a bit off.
I am working on this. This is part of follow-up PRs that I am intending to make soon. |
I have aligned both titles now. For the sake of design, I had to disable the channel icon until we have a better one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
8018101
to
126a479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Small thing: The arrow for the markets looks a bit too bold compared to the headline and the padding and y position might be adjusted a bit. But no need to do that in this PR... |
That's true. I've noticed, and will make a new image for this.
Can you be more specific? I see it centered. "BTC/EUR" is in the middle of the y axis, and then the description continues on the same line. This is by design. |
I meant only the arrow down icon for the drop down. It feels to me 1 px too low and maybe 1-2 px too much left. |
Yeah, I did not go pixel perfect there since the arrow (as discussed before) is incorrect. Will fix paddings when I introduce the new arrow in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Hi @axpoems, I can't merge this PR due to a merge conflict in |
Temporarily disable the channel icon.
126a479
to
8ddc8e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Introduce improvements in new design for public channels (BisqEasy offerbook, and domains Discussions, Events and Support).
Offerbook:
Events domain:
I will follow-up with another PR regarding improvements in private chats and other further design reviews.