Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a hint about filters being applied to offerbook channel list #1740

Closed
namloan opened this issue Mar 5, 2024 · 3 comments · Fixed by #1751
Closed

Display a hint about filters being applied to offerbook channel list #1740

namloan opened this issue Mar 5, 2024 · 3 comments · Fixed by #1751

Comments

@namloan
Copy link
Contributor

namloan commented Mar 5, 2024

It would be good to provide a hint in the UX that there are some filters applied to the markets. If the 'With offers' filter is applied and a market without offers is selected, the channel selection list appears empty and it's not straightforward to understand why + it's impossible to switch to a channel without offers unless the user finds out that they need to switch to the 'All' filter.

The solution could be as simple as changing the color of the filter to something that signals that there is a filter applied (e.g., yellow). The 'With offers' filter is currently the default filter - we should probably switch it to 'All' as channels will be ranked by 'Most offers' by default anyways. This way a new user will be able to easily see all the markets available at first sight and we reduce the risk of abandonment because of misleading new users into thinking that the market in which they're interested is not available.

Screenshot 2024-03-05 at 10 03 49
Screenshot 2024-03-05 at 10 04 02

@axpoems
Copy link
Contributor

axpoems commented Mar 5, 2024

Thanks for your inputs @namloan!

The solution could be as simple as changing the color of the filter to something that signals that there is a filter applied (e.g., yellow).

I wouldn't change icon colours at this moment. Instead, I think it would good to have a more informative placeholder (rather than No content in table).

The 'With offers' filter is currently the default filter - we should probably switch it to 'All' as channels will be ranked by 'Most offers' by default anyways. This way a new user will be able to easily see all the markets available at first sight and we reduce the risk of abandonment because of misleading new users into thinking that the market in which they're interested is not available.

I initially had All markets, then I changed it to With offers. The question is, how many markets will have offers? If there's a lot, then it could be ok to leave it as is.
In any case, I think it would be good to always see the selected market (regardless of whether we have a filter applied or not).

Would you like to work on this?

@namloan
Copy link
Contributor Author

namloan commented Mar 6, 2024

I'm a Bisq1 user and a Bisq2 contributor and it took me a while to figure out how to switch the market. I could be biased as I was familiar with the previous Bisq2 offerbook look but I thought that if it was difficult for me, then the risk for new users to just abandon the application could be high.

I wouldn't change icon colours at this moment.

Just to be clear I wasn't necessarily proposing this as the best solution, just thinking on stuff that would have gave me a hint that filters were being applied. You probably have better inputs there / know best what's the best standard to follow. I'm interested in the reasoning.

I think it would good to have a more informative placeholder

The problem with this is that the placeholder would only be displayed when the list is empty right?

I still feel there is something off about having filters applied and not getting this signal from anywhere - maybe because it's a common pattern in web. Examples from Amazon and Shein ('filters applied' signals in the top left):

Screenshot 2024-03-06 at 09 57 05
Screenshot 2024-03-06 at 10 00 23

The question is, how many markets will have offers? If there's a lot, then it could be ok to leave it as is.

If there were a lot, I think this could even be more problematic - a user looking for a market that doesn't have offers when there are a lot of markets with offers may be mislead to think that Bisq2 isn't supporting that market.

Would you like to work on this?

I don't have capacity to take on this right now, would like to close first some other work that I have pending.

@axpoems
Copy link
Contributor

axpoems commented Mar 7, 2024

The offerbook is currently under revision, so I'll take your inputs into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants