Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emzy bsq explorer #7213

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Remove emzy bsq explorer #7213

merged 1 commit into from
Sep 8, 2024

Conversation

HenrikJannsen
Copy link
Collaborator

No description provided.

@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.18 milestone Jul 25, 2024
alejandrogarcia83
alejandrogarcia83 previously approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen dismissed alejandrogarcia83’s stale review July 25, 2024 19:12

The merge-base changed after approval.

alejandrogarcia83
alejandrogarcia83 previously approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83
Copy link
Contributor

I can't merge this PR due to merge conflicts. Please resolve them. Thank you!

@HenrikJannsen
Copy link
Collaborator Author

If we remove new BlockChainExplorer("mempool.bisq.services (@devinbileck)", "https://mempool.bisq.services/bisq/tx/", "https://mempool.bisq.services/bisq/address/") we don't have any BSQ explorer as the one from emzy got removed as well.

@devinbileck Is it ok to leave that BSQ exlorer until we have added a new one?

@HenrikJannsen
Remove emzy bsq explorer from BSQ_MAIN_NET_EXPLORERS.
c851111 
Remove that entyr if it was used as persisted explorer.

Signed-off-by: HenrikJannsen <[email protected]>
@HenrikJannsen HenrikJannsen force-pushed the remove-emzy-bsq-explorer branch from b10e033 to c851111 Compare July 26, 2024 12:21
@HenrikJannsen
Copy link
Collaborator Author

Rebased

@devinbileck
Copy link
Member

If we remove new BlockChainExplorer("mempool.bisq.services (@devinbileck)", "https://mempool.bisq.services/bisq/tx/", "https://mempool.bisq.services/bisq/address/") we don't have any BSQ explorer as the one from emzy got removed as well.

@devinbileck Is it ok to leave that BSQ exlorer until we have added a new one?

Yes, that is fine to leave it running for now.

This was referenced Aug 5, 2024
Open
Open
@runbtc
Copy link
Contributor

runbtc commented Aug 8, 2024

You can add my BSQ explorer. It is not available via clearnet, but is available via onion service.
http://runbtcxzz4v2haszypwbrn2baqdo7tlwt6dw7g27cwwaootd4gktwayd.onion/

@devinbileck devinbileck mentioned this pull request Sep 5, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@HenrikJannsen
Copy link
Collaborator Author

Still relevant

alejandrogarcia83
alejandrogarcia83 approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit e9784b6 into bisq-network:master Sep 8, 2024
3 checks passed
@devinbileck devinbileck mentioned this pull request Oct 9, 2024
Open
@devinbileck devinbileck mentioned this pull request Nov 8, 2024
Open
@devinbileck devinbileck mentioned this pull request Dec 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.19
Development

Successfully merging this pull request may close these issues.
4 participants
@HenrikJannsen @alejandrogarcia83 @devinbileck @runbtc