-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require the DAO is enabled for traders #6403
Merged
sqrrm
merged 9 commits into
bisq-network:master
from
HenrikJannsen:disable-deactivation-of-dao
Nov 4, 2022
Merged
Require the DAO is enabled for traders #6403
sqrrm
merged 9 commits into
bisq-network:master
from
HenrikJannsen:disable-deactivation-of-dao
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HenrikJannsen <[email protected]>
…ays true Signed-off-by: HenrikJannsen <[email protected]>
…ed is always true Signed-off-by: HenrikJannsen <[email protected]>
… isDaoActivated is always true the whole statement is always false Signed-off-by: HenrikJannsen <[email protected]>
…` as isDaoActivated is always true In case of a `||` the statement gets removed as it always is true. At getUserPaymentAccounts we refactor further the steam to a HashSet constructor operation as the filter method gets removed. Signed-off-by: HenrikJannsen <[email protected]>
Remove daoActivatedToggleButton from PreferencesView and NewsView Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
HenrikJannsen
changed the title
Disable deactivation of dao
Require the DAO is enabled for traders
Nov 3, 2022
Signed-off-by: HenrikJannsen <[email protected]>
ghost
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
sqrrm
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements bisq-network/proposals#384
Required for bisq-network/proposals#390