-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to copy addresses / transaction ids #6314
Conversation
@xyzmaker123 Appreciate the PR, but I have a question about a possible stylistic improvement. The clickable href and chain icon at the moment do the same thing which seems redundant. How about switching the chain icon with a copy icon, using that to copy to the clipboard. So if the user wants to open in a browser, they click the href or if just want to copy then click on the icon? |
@xyzmaker123 Replacing the link icon with a copy icon sounds good to me. Do this PR fix both the funds and the DAO section? |
Let's wait for @ripcurlx confirmation that replacing icon is okay - concept with icon for the link seems to be really old in bisq and it's used also for different kind of links - it probably has some UX grounds.
Yes |
ATM the chain icon is (should) be an indication next to all links that will guide the user to an external url. I'm not sure if it is worth in this case to replace it with a copy icon. |
Yeah, I think current solution with copy menu after click right mouse button is good enough. ... Pushed conflicts fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Fixes #5278, Fixes #4452
Preview: