Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to copy addresses / transaction ids #6314

Merged
merged 2 commits into from Aug 20, 2022
Merged

Possibility to copy addresses / transaction ids #6314

merged 2 commits into from Aug 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2022

Fixes #5278, Fixes #4452

Preview:
copy

@ghost
Copy link

ghost commented Aug 14, 2022

@xyzmaker123 Appreciate the PR, but I have a question about a possible stylistic improvement.

The clickable href and chain icon at the moment do the same thing which seems redundant. How about switching the chain icon with a copy icon, using that to copy to the clipboard. So if the user wants to open in a browser, they click the href or if just want to copy then click on the icon?

@ghost
Copy link
Author

ghost commented Aug 14, 2022

Thanks @jmacxx - for me replacing link icon with copy icon sounds good. I implemented current solution based on @ripcurlx and @pazza83 comments - I'd like to hear their opinion before reimplementing it

@pazza83
Copy link

pazza83 commented Aug 14, 2022

@xyzmaker123 Replacing the link icon with a copy icon sounds good to me.

Do this PR fix both the funds and the DAO section?

@ghost
Copy link
Author

ghost commented Aug 15, 2022

Let's wait for @ripcurlx confirmation that replacing icon is okay - concept with icon for the link seems to be really old in bisq and it's used also for different kind of links - it probably has some UX grounds.

Do this PR fix both the funds and the DAO section?

Yes

@ripcurlx
Copy link
Contributor

Let's wait for @ripcurlx confirmation that replacing icon is okay - concept with icon for the link seems to be really old in bisq and it's used also for different kind of links - it probably has some UX grounds.

Do this PR fix both the funds and the DAO section?

Yes

ATM the chain icon is (should) be an indication next to all links that will guide the user to an external url. I'm not sure if it is worth in this case to replace it with a copy icon.

@ghost
Copy link
Author

ghost commented Aug 17, 2022

ATM the chain icon is (should) be an indication next to all links that will guide the user to an external url. I'm not sure if it is worth in this case to replace it with a copy icon.

Yeah, I think current solution with copy menu after click right mouse button is good enough.

...

Pushed conflicts fix

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.9.5 milestone Aug 20, 2022
@ripcurlx ripcurlx merged commit aa1891a into bisq-network:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants