Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with extraData field when editing offer #5651

Merged
merged 1 commit into from Aug 16, 2021
Merged

Fix issue with extraData field when editing offer #5651

merged 1 commit into from Aug 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2021

Reported by @stakoholic, when editing an offer some information was not being transferred.

extraData is used for the account age and other custom fields like F2F city.
So when editing an offer the extraData should be obtained from the edited offer not the original one.

Fixes #5597
FYI @ghubstan this one line fix also needs carrying over to the current editoffer API work.


Testing:

You have an Amazon gift card account which is 4 days old (for example).
Create an F2F account which specifies city as 'Paris' and additional information as "ask for Freddie".

Prior version: (bug)

  • Create offer to buy 0.01 BTC using Amazon gift card.
  • Edit the offer changing payment account to F2F.
  • Look at the offer in the order book.
  • It should show the F2F city ('Paris') but it is blank.
  • It should show additional information ("ask for Freddie") but it is blank.
  • It should show the account age as 0 days old but instead shows it as 4 days old.

image

Version with fix applied:

  • Create offer to buy 0.01 BTC using Amazon gift card.
  • Edit the offer changing payment account to F2F.
  • Look at the offer in the order book.
  • It shows the F2F city ('Paris').
  • It shows additional information as "ask for Freddie".
  • It shows the account age as 0 days old.

image

@ghubstan
Copy link
Contributor

ghubstan commented Aug 4, 2021

FYI @ghubstan this one line fix also needs carrying over to the current editoffer API work.

@jmacxx Thanks for the heads up. I do need to adjust the api to this change.

You seem to already know it only affects new api method editoffer, which has not been merged into master yet. And, api method editoffer v1 cannot change payment acct details -- just offer price details. But I plan to make the change this week.

@ripcurlx ripcurlx added this to the v1.7.3 milestone Aug 16, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit b9038fc into bisq-network:master Aug 16, 2021
ghubstan added a commit to ghubstan/bisq that referenced this pull request Aug 16, 2021
@ghost ghost deleted the fix_edit_offer_extra_data branch May 29, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

account info in orderbook was not changed to the related trading account
2 participants