Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue for deprecated payment account imported from backup #5644

Merged
merged 1 commit into from Aug 1, 2021
Merged

Fix issue for deprecated payment account imported from backup #5644

merged 1 commit into from Aug 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 30, 2021

When importing payment accounts from a backup file, we have to guard for the fact that deprecated accounts may be present so test for null. This is the same as #5614 except applied to the account backup file.

Thanks to @KISBITCOIN for discovering this.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.7.3 milestone Aug 1, 2021
@ripcurlx ripcurlx merged commit fa4238c into bisq-network:master Aug 1, 2021
@ghost ghost mentioned this pull request Aug 19, 2021
@ghost ghost deleted the fix_payment_account_deserialize_issue branch May 29, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant