Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LTC accounts to use segwit addresses #5639

Merged
merged 1 commit into from Aug 1, 2021
Merged

Allow LTC accounts to use segwit addresses #5639

merged 1 commit into from Aug 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2021

Fixes issue described by a user here:

https://old.reddit.com/r/bisq/comments/omf3l3/cannot_add_ltc_account/

Under "altcoin accounts" I'm trying to add the address of my LTC core wallet.
Neither regular nor Bech32 addresses works. Anyone know How I'd go about adding LTC?


Implementation:

  • The address validator specified the bitcoin magic number for wrapped segwit, 5 -- it should be 50 for LTC.
  • The address validator expected base58 only (legacy format). Changed to use an address validator that supports bech32 and base58.

Testing:

Added tests for wrapped segwit and bech32 address formats.


image

image

@boring-cyborg boring-cyborg bot added in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now labels Jul 27, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 5bcc207 into bisq-network:master Aug 1, 2021
@ripcurlx ripcurlx added this to the v1.7.3 milestone Aug 1, 2021
@ghost ghost mentioned this pull request Aug 19, 2021
@ghost ghost deleted the litecoin_account_segwit branch October 5, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant