Add Capitual payment method #5501
Conversation
|
@pazza83 do you have any update on final info text to add? Thanks! |
|
Hi @BtcContributor still waiting for my feedback on this comment from @m52go I do not think any special information is needed. Let me know if you think I am overlooking anything |
desktop/src/main/java/bisq/desktop/components/paymentmethods/CapitualForm.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/paymentmethods/CapitualForm.java
Outdated
Show resolved
Hide resolved
|
Applied feedbacks from @KaiWitt (thanks!) and added text suggestion from @pazza83 I think now it is ready to be moved to final PR and no draft anymore :) |
| @@ -3466,7 +3467,7 @@ payment.amazonGiftCard.info=To pay with Amazon eGift Card, you will need to send | |||
| - try to use creative, believable text for the gift card''s message (e.g., "Happy birthday Susan!") along with the trade ID (and use trader chat \ | |||
| to tell your trading peer the reference text you picked so they can verify your payment)\n\ | |||
| - Amazon eGift Cards can only be redeemed on the Amazon website they were purchased on (e.g., a gift card purchased on amazon.it can only be redeemed on amazon.it) | |||
|
|
|||
| payment.capitual.info=Include any special instructions for the payment method that both buyer and seller might need to be aware of | |||
There was a problem hiding this comment.
FYI this line actually shows in the software...it should probably be removed.
There was a problem hiding this comment.
So, no popup or different text?
There was a problem hiding this comment.
I would say if there's no text worth putting there, there should be no pop-up.
There was a problem hiding this comment.
Please remove this unused translation.
|
@BtcContributor I completely missed this PR for the v1.7.2 release. Is this PR ready to be reviewed and tested? |
Ok - I'll test and cherry-pick it for the release if everything looks fine tomorrow. |
Implement bisq-network/growth#246
Waiting for final Info text to be suggested by @pazza83
In the meantime, if you have any feedback on this please let me know :)