Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dark mode readibility of specific texts #5232

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Fix dark mode readibility of specific texts #5232

merged 2 commits into from
Mar 11, 2021

Conversation

BtcContributor
Copy link
Contributor

Fixes #5230

Fixed the original issue case and an another similar one.

@BtcContributor BtcContributor mentioned this pull request Feb 27, 2021
Closed
ripcurlx
ripcurlx suggested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - I think the color and opacity for light mode is fine. It just needs a different color in css for dark mode to make it more readable.

@BtcContributor
Copy link
Contributor Author

Sorry @ripcurlx, now I get it.
CSS changed, now it should be correct.

bisq

@BtcContributor BtcContributor requested a review from ripcurlx March 11, 2021 12:26
@ripcurlx
Copy link
Contributor

I think it doesn't have any effect on other UI faint focus outlines as we use the jfoenix library. But let's keep an eye open during next testing release cycle.

@ripcurlx ripcurlx merged commit 944fa7e into bisq-network:master Mar 11, 2021
@BtcContributor BtcContributor deleted the darkread branch March 11, 2021 15:24
@ripcurlx ripcurlx added this to the v1.6.0 milestone Mar 11, 2021
@BtcContributor BtcContributor restored the darkread branch March 19, 2021 14:28
@BtcContributor BtcContributor mentioned this pull request Mar 19, 2021
Merged
@BtcContributor BtcContributor mentioned this pull request Mar 30, 2021
Closed
@ripcurlx ripcurlx mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Fix color of message status information in Dark mode
2 participants
@BtcContributor @ripcurlx