Remove address prefix for mailbox messages #4609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `boolean contains(Capability capability)` method
Set address prefix to empty bytes in case we know that peer has capability (updated version) Batch process mailbox messages in a thread. Refactor handling of mailbox messages
Improve logs
…thod Return early
Make capabilities final If capability changes we would have had duplicate entries
… will be done in next commits Cleanups
chimp1984
force-pushed
the
remove-address-prefix-for-mailbox-messages
branch
from
63ce5a6 to
fc0082a
Compare
chimp1984
changed the title
The check for AckMessage is not needed anymore as we remove the interface from AckMessage
Impl. applyCapabilities Cleanups
Rename getOptionalPersistedPeer to findPersistedPeer Improve getConnectedReportedPeers method
sqrrm
reviewed
Oct 7, 2020
Co-authored-by: sqrrm <[email protected]>
Co-authored-by: sqrrm <[email protected]>
…onnection.hasPeersNodeAddress() which does the same internally
…node from persisted peers. Remove log in DisputeAgentManager which gets called repeatedly
Rename method
…erialisation Remove final Cleanups
chimp1984
changed the title
|
Complete with dev testing... |
Rename mailboxMap to mailboxItemsByUid
sqrrm
reviewed
Oct 8, 2020
p2p/src/main/java/bisq/network/p2p/peers/peerexchange/PeerExchangeManager.java
Outdated
Show resolved
Hide resolved
Fix incorrectly commented out code (was for dev testing commented out)
chimp1984
added a commit
to chimp1984/bisq
that referenced
this pull request
Oct 8, 2020
…w. This is not the case without getting PR bisq-network#4609 merges as well. We only do it for 2 weeks after planned release time as then it can be assumed that enough nodes have updated that the normal publishing will distribute the object sufficiently.
…orted one has higher capabilities, otherwise we ignore it.
Merged
|
Replaced by #4610 |
chimp1984
added a commit
to chimp1984/bisq
that referenced
this pull request
Oct 8, 2020
…w. This is not the case without getting PR bisq-network#4609 merges as well. We only do it for 2 weeks after planned release time as then it can be assumed that enough nodes have updated that the normal publishing will distribute the object sufficiently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove address prefix in case the peer has updated vesion as well.
Processes all mailbox messages in a thread. (1000 msgs takes about 1 sec).
EDIT: Merged master and rebased
Capability handling is still WIP