Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature to dispute result and various other improvements #4543

Merged
merged 42 commits into from
Sep 25, 2020

Conversation

chimp1984
Copy link
Contributor

@chimp1984 chimp1984 commented Sep 21, 2020

Depends on #4542

Add various new features to dispute domain.

  • Add signature to summary message and validation popup so the signature and the msg can be validated
  • Allows refund agent to close cases without a payout
  • Adds validation for node addresses, deposit and payout txs and donation address
  • Add copy as csv button at report screen for dispute agents
  • Improves search field and shows tooltip if match is found from which source the match was made (e.g. deposit Tx, json,..)

We must not add main net addresses if not on mainnet
…agent-branch

# Conflicts:
#	core/src/main/java/bisq/core/support/dispute/DisputeManager.java
#	desktop/src/main/java/bisq/desktop/main/support/dispute/agent/DisputeAgentView.java
# Conflicts:
#	desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java
…sq.core.util.validation

Add RegexValidatorFactory
Move regex tests from GUIUtilTest to new RegexValidatorTest class
@chimp1984 chimp1984 changed the title Dispute agent branch Dispute domain improvements Sep 21, 2020
@chimp1984 chimp1984 changed the title Dispute domain improvements Add signature to dispute result and various more improvements Sep 21, 2020
@chimp1984 chimp1984 changed the title Add signature to dispute result and various more improvements Add signature to dispute result and various other improvements Sep 21, 2020
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a good change, but since the verification is added I think it should be made automatic to be actually useful and not just add confusion.

@chimp1984
Copy link
Contributor Author

Overall this is a good change, but since the verification is added I think it should be made automatic to be actually useful and not just add confusion.

The verification is not for the users themself but for DAO voter to verify a reimbursement request. So they have an easy way to verify. The trader need to copy paste the summary msg and voters verify it. They dont have the data so they could not do it automatically.

@sqrrm
Copy link
Member

sqrrm commented Sep 25, 2020

Ah, that makes more sense. Could still add auto check for refund agent but that's less important I suppose.

@chimp1984
Copy link
Contributor Author

Ah, that makes more sense. Could still add auto check for refund agent but that's less important I suppose.

Yes sould be probably added. I will make a new PR for that once that is merged.

@sqrrm
Copy link
Member

sqrrm commented Sep 25, 2020

Only thing left to fix is the log level, then merge.

@sqrrm
Copy link
Member

sqrrm commented Sep 25, 2020

@chimp1984 looks like there is a conflict now.

Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit 2c252e9 into bisq-network:master Sep 25, 2020
@chimp1984 chimp1984 deleted the dispute-agent-branch branch September 27, 2020 06:28
@ripcurlx ripcurlx added this to the v1.4.0 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants