Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract btc to segwit addresses #4509

Merged
merged 7 commits into from
Sep 21, 2020
Merged

Extract btc to segwit addresses #4509

merged 7 commits into from
Sep 21, 2020

Conversation

oscarguindzberg
Copy link
Contributor

Allow users to extract their BTC funds to external segwit addresses.
Users can't use segwit addresses to receive funds yet.
Please, don't merge until #4504 is merged.

@boring-cyborg boring-cyborg bot added in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now labels Sep 9, 2020
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Sep 10, 2020
@oscarguindzberg oscarguindzberg force-pushed the extract_to_segwit branch 2 times, most recently from 892e904 to 1025092 Compare September 15, 2020 19:05
chimp1984
chimp1984 previously approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@oscarguindzberg oscarguindzberg force-pushed the extract_to_segwit branch 2 times, most recently from 90681bf to 921cd07 Compare September 18, 2020 22:37
chimp1984
chimp1984 previously approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984
Copy link
Contributor

@oscarguindzberg the WIP prefix can be removed, right?

wiz
wiz previously approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - tested OK
Screen Shot 2020-09-22 at 0 19 54

@oscarguindzberg oscarguindzberg dismissed stale reviews from wiz and chimp1984 via 93f9f83 September 21, 2020 15:42
@oscarguindzberg oscarguindzberg changed the title [WIP] Extract btc to segwit addresses Extract btc to segwit addresses Sep 21, 2020
@oscarguindzberg
Copy link
Contributor Author

  • Signed my commits.
  • Removed WIP.
  • This PR is ready to be merged.

@oscarguindzberg oscarguindzberg mentioned this pull request Sep 21, 2020
Closed
chimp1984
chimp1984 reviewed Sep 21, 2020
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ripcurlx
ripcurlx approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #4509 (review)

@ripcurlx ripcurlx merged commit 0cb70da into bisq-network:master Sep 21, 2020
@ripcurlx ripcurlx added this to the v1.4.0 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 left review comments

@ripcurlx ripcurlx ripcurlx approved these changes

@wiz wiz wiz left review comments

Assignees
No one assigned
Labels
in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oscarguindzberg @chimp1984 @ripcurlx @wiz