Move gRPC boilerplate from :core to :daemon #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves gRPC boilerplate classes from the :core.grpc pkg into a new :daemon.grpc pkg. * The :core.grpc pkg was renamed :core.api, and no longer has any dependencies on gRPC libraries. * All core service classes in the :core.api pkg are now package protected, excepting CoreApi, making CoreApi the only possible entry point for all Grpc*Service -> -Core*Service calls. * All grpc service classes in the :daemon.grpc pkg are now package protected, excepting GrpcServer; the only class depending on Grpc*Service class is GrpcServer. * gRPC dependencies were moved from the gradle.build file's :core subproject to :daemon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves
gRPCboilerplate code from the:core.grpcpkg into a new:daemon.grpcpkg.The
:core.grpcpkg was renamed:core.api, and no longer has a dependency ongRPClibs.All core service classes in the
:core.apipkg are now package protected, exceptingCoreApi, makingCoreApithe only possible entry point for allGrpc*Service -> Core*Servicecalls.All
gRPCservice classes in the:daemon.grpcpkg are now package protected, exceptingGrpcServer; the only class depending onGrpc*Serviceclass isGrpcServer.gRPCdependencies were moved from thegradle.buildfile's:coresubproject to:daemon.This PR replaces 4417.