Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use different css for dev mode #4415

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

sqrrm
Copy link
Member

@sqrrm sqrrm commented Aug 18, 2020

This is to help differentiate dev instances and live ones.
This can help devs avoiding silly mistakes.

Small thing, but a different color really helps sometimes.

@wiz
Copy link
Contributor

wiz commented Aug 18, 2020

Cool idea, obviously Testnet should be a different color. To take it even further tho, is the additional command line option even necessary? Seems like you could just check isDevMode() in the loadSceneStyles() and load the theme-dev.css

@sqrrm
Copy link
Member Author

sqrrm commented Aug 19, 2020

It would be a bit annoying to do UI development if the UI isn't looking like prod so I figured it's better to have it as a separate option.

@sqrrm
Copy link
Member Author

sqrrm commented Aug 28, 2020

@ripcurlx The codacy settings for css indentation seems off as well, it's expecting 2 characters rather than 4.

@ripcurlx
Copy link
Contributor

@ripcurlx The codacy settings for css indentation seems off as well, it's expecting 2 characters rather than 4.

I already updated this some time ago. I tried to re-analyze, but if it doesn't work I'll ignore this pattern here for now as well.

@ripcurlx
Copy link
Contributor

ripcurlx commented Sep 1, 2020

@sqrrm I removed the pattern for now. Could you please force push to this branch so it is getting rebuilt in Codacy? Thanks!

This is to help differentiate dev instances and live ones.
This can help devs avoiding silly mistakes.
@sqrrm
Copy link
Member Author

sqrrm commented Sep 1, 2020

@ripcurlx thanks, at least codacy is not complaining. Let's re-enable stuff if we notice there is a need for it to keep the balance of helpfulness and annoyance.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 095c8b5 into bisq-network:master Sep 2, 2020
@ripcurlx ripcurlx added this to the v1.3.8 milestone Sep 2, 2020
@sqrrm sqrrm deleted the dev-css branch May 3, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants