Send signed witness to counterparty #4314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add orphaned witness log
Better filter for root signedwitnesses Add debug keyboard shortcuts: - ctrl+shift+L -> logSignedWitnesses - ctrl+shift+S -> logSigners
Improve debug logging. Lower level from warning to info Fix broken test Add example code to clean out unnecessary SignedWitnesses
Legacy arbitrator can sign unsigned signed witness signer pubkeys To sign, from legacy arbitrator support, ctrl+O
Return the signed witness when signed by a trader
|
@sqrrm Please resolve the conflict - thanks! |
|
I think this merge conflict should be resolved once #4280 is merged since I fixed the same conflict there |
ripcurlx
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
ACK
Tested it on regtest with both clients on the new version and a regression test with the buyer on the old version. During the regression test an error is logged that has no effect on the trade process as the new message type is not known by the client. So everything is working as expected.
|
Travis issues, will create new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signer sends SignedWitness to signee after trade is completed. This allows the signee to make sure their witness is properly published in case the signer isn't well connected. An extra measure to assure that signed witnesses are well distributed upon signing.
I made this on top of PR #4280 as it's touching a lot of the same code. That PR should be merged before this one.