Add wallets protection api tests #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the ambiguity in the original class name, which implied it was a btc wallet service, not a bsq and btc wallets service.
This commit includes the following changes: * New tests for methods `lockwallet`, `unlockwallet`, `removewalletpassword`, and `setwalletpassword`. * New `getbalance` method error handing tests to verify error message correctness when wallet is locked. * Update to `getversion` method test -- now expects `1.3.4`. * Check for new `[params]` column header in help text.
This was referenced Jun 12, 2020
dmos62
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR should be merged after PR 4295. Its branch is based on PR 4295's branch.)
This commit includes the following changes:
New tests for methods
lockwallet,unlockwallet,removewalletpassword, andsetwalletpassword.New
getbalancemethod error handing tests to verifyerror message correctness when wallet is locked.
Update to
getversionmethod test -- now expects1.3.4.Check for new
[params]column header in help text.This PR replaces 4243, which had not been kept in sync with commits to tested methods in 4214. It also replaces 4268, which was based on a stale main branch.
Running the test suite will verify all tests pass
(1) Clone and build branch
wallets-protection-api-tests(2) Run the server on Linux or OSX:
(3) Let the server initialize (sync) for at least 2 minutes.
(4) Run the bats test suite:
All tests should pass.