Fix proof-of-burn signing for password protected wallets #4221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing
bsqWalletService.isEncrypted()
check and optional AES key argument to thesignMessage(..)
call inProofOfBurnService
, analogous to the BitcoinJ call to sign with an EC key inMyBlindVoteListService
.This fixes #3836 (Proof of burn signing does not work if wallet password is set).
--
Unfortunately this PR touches the core DAO packages again, although it is fairly trivial.