Fix Trader Chat row selection and unread message count #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operly The trader chat view can be opened either by clicking on the chat icon of a trade in the list, or clicking on "OPEN TRADER CHAT" button for the currently displayed trade. In the latter case, the count of new messages displayed on the chat icon was not cleared even though trader chat was shown. The solution is to move the scope of the routine that updates trader chat message count from within the table cell handler to the PendingTradesView class so that it can be called whenever onChat() is invoked (i.e. when the Trader Chat screen is shown). Clicking on the trader chat icon of a trade that is not selected should select that row in the trade list. It does not. This causes confusion as it gives misleading cues as to which trader you are communicating with. Issue a call to select the row of the button when clicked. Fixes #4172
ghost
mentioned this pull request
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still relevant. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on the trader chat icon of a trade that is not selected should select that row in the trade list. It does not. This causes confusion as it gives misleading cues as to which trader you are
communicating with. Issue a call to select the row of the button when clicked.
The trader chat view can be opened either by clicking on the chat icon of a trade in the list, or clicking on "OPEN TRADER CHAT" button for the currently displayed trade. In the latter case, the count of new messages displayed on the chat icon was not cleared even though trader chat was shown. The solution is to move the scope of the routine that updates trader chat message count from within the table cell handler to the PendingTradesView class so that it can be called whenever
onChat() is invoked (i.e. when the Trader Chat screen is shown).
Fixes #4172