Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When accepting an offer do not round the BTC amount outside range #4178

Merged
merged 1 commit into from May 11, 2020
Merged

When accepting an offer do not round the BTC amount outside range #4178

merged 1 commit into from May 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2020

Fixes #3871. The BTC amount of an offer was being adjusted up in certain cases due to a rounding calculation from the fiat value and price. This would prevent some offers from being taken.

There's an existing check to ensure that the amount is not adjusted below the minimum, here we add a check to ensure that the amount is not adjusted higher than the maximum defined in the offer.

Fixes 3871.  The BTC amount of an offer was being adjusted up in
certain cases due to a rounding calculation from the fiat value
and price.  This would prevent some offers from being taken.

There's an existing check to ensure that the amount is not adjusted
below the minimum, here we add a check to ensure that the amount
is not adjusted higher than the maximum defined in the offer.
@ripcurlx ripcurlx added this to the v1.3.3 milestone Apr 20, 2020
@sqrrm sqrrm modified the milestones: v1.3.4, v1.3.5 May 11, 2020
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit d51c4c8 into bisq-network:master May 11, 2020
@ghost ghost mentioned this pull request May 12, 2020
@ghost ghost deleted the fix_issue_3871 branch June 29, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Price rounding with fixed price
2 participants