Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v1.3.2 #4175

Merged
merged 14 commits into from
Apr 16, 2020
Merged

Release/v1.3.2 #4175

merged 14 commits into from
Apr 16, 2020

Conversation

ripcurlx
Copy link
Contributor

No description provided.

ripcurlx and others added 13 commits April 10, 2020 20:02
Add more logging during unfail process
Test AccountAgeWitnessServiceTest > testArbitratorSignWitness failed
in full gradle build, but passed when run as a single test:

	./gradlew :core:cleanTest :core:test \
		--tests "bisq.core.account.witness.AccountAgeWitnessServiceTest"

This test also passed when run in the IDE.

Solved by not passing a mocked PaymentMethod.SEPA argument into the
test's service.getTraderPaymentAccounts() method, where mock paymentId
field was null when running full build's test suites.

Fix for #4158
Add second donation address as valid
@ripcurlx ripcurlx requested a review from cbeams as a code owner April 16, 2020 11:44
@ripcurlx ripcurlx requested a review from sqrrm April 16, 2020 11:48
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 2db90cf into master Apr 16, 2020
@ripcurlx ripcurlx deleted the release/v1.3.2 branch October 8, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants