Replace mock arg with SEPA PaymentMethod instance #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test AccountAgeWitnessServiceTest > testArbitratorSignWitness failed in full gradle build, but passed when run as a single test: ./gradlew :core:cleanTest :core:test \ --tests "bisq.core.account.witness.AccountAgeWitnessServiceTest" This test also passed when run in the IDE. Solved by not passing a mocked PaymentMethod.SEPA argument into the test's service.getTraderPaymentAccounts() method, where mock paymentId field was null when running full build's test suites. Fix for bisq-network#4158
|
close & reopen to force travis build |
ripcurlx
added
the
is:priority
ripcurlx
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test AccountAgeWitnessServiceTest > testArbitratorSignWitness failed
in full gradle build, but passed when run as a single test:
This test also passed when run in the IDE.
Solved by not passing a mocked PaymentMethod.SEPA argument into the
test's service.getTraderPaymentAccounts() method, where mock paymentId
field was null when running full build's test suites.
Fixes #4158