Upgrade firebase-admin, avoid gRPC version conflict #4088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghubstan
force-pushed
the
upgrade-firebase-admin
branch
2 times, most recently
from
06596cf to
1a4451e
Compare
The latest firebase-admin (v6.12.2) depends on grpc-api v1.24.1, which is as close as we can get to the grpc v1.25.0 specified in build.gradle. Currently, the firebase-admin version requirement is causing the build to download grpc v1.10.1 jars, but at runtime, grpc 1.25.0 jars are loaded. Transitive dependencies grpc-netty-shaded, grpc-protobuf, grpc-protobuf-lite, grpc-protobuf-stub, grpc-protobuf-grpclb (v1.23.0) are also excluded. Upgraded slf4j version requirement to match that of other dependencies. This removes a duplicated dependency, and corrects the gradle-witness.gradle slf4-api entry, which verified slf4-api v1.7.22, not the transitive dependency loaded at runtime. Beyond avoiding general version hell issues, eliminating version conflicts saves a dev time thinking about which source jar to choose from while examining exception stack traces. Partial fix for bisq-network#4086
ghubstan
force-pushed
the
upgrade-firebase-admin
branch
from
baa92ae to
ca18bc3
Compare
|
This has to be cancelled because it breaks bisq-daemon. PR #4089 is OK (it just upgrades apache and logback deps.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest firebase-admin (v6.12.2) depends on grpc-api v1.24.1,
which is as close as we can get to the grpc v1.25.0 specified in
build.gradle. Currently, the firebase-admin version requirement
is causing the build to download grpc v1.10.1 jars, but at runtime,
grpc 1.25.0 jars are loaded.
Transitive dependencies grpc-netty-shaded, grpc-protobuf, grpc-protobuf-lite,
grpc-protobuf-stub, grpc-protobuf-grpclb (v1.23.0) are also excluded.
Eliminating version conflicts saves a dev time thinking about which
source jar to choose from while examining exception stack traces.
Partial fix for #4086