Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docker install of Pricenode #4041

Closed
wants to merge 7 commits into from

Conversation

mrosseel
Copy link
Contributor

  • update of the docker installation for its new location (main bisq repo)
  • adopted the builder/runner docker pattern to limit image size

PS: I'm aware there's a debian install script, but I want at least one guy running something else than debian + that script in case there are bugs/vulnerabilities specific to that combination of OS and install method.

@mrosseel mrosseel requested a review from cbeams as a code owner March 10, 2020 15:01
@ripcurlx
Copy link
Contributor

@mrosseel Please have a look at the Codacy issues: https://app.codacy.com/gh/bisq-network/bisq/pullRequest?prid=5153686. Thanks!

@mrosseel
Copy link
Contributor Author

mrosseel commented Apr 19, 2020

The pricenode scripts have been updated with collectd reporting, and since they heavily use systemd/journalctl which are hard to do in docker, I had to abandon the pricenode docker approach. It's possible to convert but too much work atm.
These new scripts are easy to use so that's fine, only possible downside is that all pricenodes are running on debian (just a guess) and are one bad update/zero day away from all going down at once. If this becomes a priority ops issue I can look at it again, until then I'm going with the flow ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants