Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SNAPSHOT versioning differently for rpm packages #4009

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Handle SNAPSHOT versioning differently for rpm packages #4009

merged 1 commit into from
Feb 27, 2020

Conversation

ripcurlx
Copy link
Contributor

Fixes #4006.

@ripcurlx ripcurlx requested a review from devinbileck February 26, 2020 08:23
@ripcurlx ripcurlx changed the title Handle SNAPSHOT versioning different for rpm packages Handle SNAPSHOT versioning differently for rpm packages Feb 26, 2020
@ripcurlx ripcurlx added the is:no-priority PR or issue marked with this label is not up for compensation right now label Feb 26, 2020
@ripcurlx ripcurlx force-pushed the fix-snapshot-version-for-rpm-builds branch from 91c7906 to 3b1a1f2 Compare February 26, 2020 08:49
devinbileck
devinbileck approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

sqrrm
sqrrm approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit ad3da4b into bisq-network:master Feb 27, 2020
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
Closed
@devinbileck devinbileck mentioned this pull request Mar 11, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Closed
@ripcurlx ripcurlx deleted the fix-snapshot-version-for-rpm-builds branch July 16, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

@devinbileck devinbileck devinbileck approved these changes

Assignees
No one assigned
Labels
is:no-priority PR or issue marked with this label is not up for compensation right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build Bisq rpm on Debian 10.3 VM
3 participants
@ripcurlx @devinbileck @sqrrm