Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 4 refreshes per trade #3980

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Allow 4 refreshes per trade #3980

merged 1 commit into from
Feb 18, 2020

Conversation

sqrrm
Copy link
Member

@sqrrm sqrrm commented Feb 17, 2020

Change refresh interval to be dependent on the trade period rather than a fix 24 hours (which is obviously not that helpful for a 1 hour trade.

ripcurlx
ripcurlx approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

So we will have ~ 29h for SEPA and 12 min for a SEPA Instant trade until a refresh can be triggered

@ripcurlx ripcurlx merged commit e7b60d2 into bisq-network:master Feb 18, 2020
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Feb 18, 2020
@ripcurlx ripcurlx added this to the v1.2.8 milestone Feb 18, 2020
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Closed
@sqrrm sqrrm deleted the fix-refresh-interval branch May 3, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
v1.2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@sqrrm @ripcurlx