Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused uid in pricefeed service #3937

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Remove unused uid in pricefeed service #3937

merged 1 commit into from
Feb 4, 2020

Conversation

freimair
Copy link
Contributor

@freimair freimair commented Feb 4, 2020

This came up during work on #3916.

Bisq frequently (once per minute) queries our price nodes for up-to-date
price information. It does so by HTTP GET request. However, it provided
a UID via the "User-Agent" HTTP header field. This UID has been a random
number which changed everytime Bisq got started up.

This UID has never been used. Thus, remove it.

@freimair
Remove unused uid in pricefeed service
af939e6 
Bisq frequently (once per minute) queries our price nodes for up-to-date
price information. It does so by HTTP GET request. However, it provided
a UID via the "User-Agent" HTTP header field. This UID has been a random
number which changed everytime Bisq got started up.

This UID has never been used. Thus, remove it.
@ripcurlx ripcurlx requested a review from wiz February 4, 2020 14:39
ripcurlx
ripcurlx approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

wiz
wiz approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great for privacy 👍

@ripcurlx ripcurlx merged commit d6de99c into bisq-network:master Feb 4, 2020
@ripcurlx ripcurlx added this to the v1.2.6 milestone Feb 4, 2020
@ripcurlx ripcurlx added re:privacy is:priority PR or issue marked with this label is up for compensation labels Feb 4, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Closed
@wiz
Copy link
Contributor

wiz commented Feb 18, 2020

@freimair you missed this one https://github.com/bisq-network/bisq/blob/master/core/src/main/java/bisq/core/provider/fee/FeeProvider.java#L48

and this one https://github.com/bisq-network/bisq/blob/master/core/src/main/java/bisq/core/notifications/MobileNotificationService.java#L300

@wiz
Copy link
Contributor

wiz commented Feb 18, 2020

pricenode still has UUID in logs

INFO  b.p.m.FeeRateController: Incoming /getFees request from: bisq/1.2.7, uid:f33c97d1-b065-48c4-bc84-eaaa680e4288

@freimair
Copy link
Contributor Author

I only focused on the stuff relevant to the networksize metric. I guess we can remove the uid for the getFee stuff as well. However, I will not touch the mobile notification stuff because I do not know how these things work in detail.

@freimair freimair mentioned this pull request Feb 27, 2020
Merged
@freimair freimair mentioned this pull request Mar 11, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
is:priority PR or issue marked with this label is up for compensation re:privacy
Projects
None yet
Milestone
v1.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@freimair @wiz @ripcurlx