Reduce number of decimals shown for monetary fiat prices to 2 #3926
Conversation
|
Thanks @ripcurlx for the review, I've pushed an update so decimals are removed for displayed fiat volume amounts. I've updated the appropriate tests and ran the
|
ghost
requested a review
from 
There was a problem hiding this comment.
ACK
I tested it locally on Regtest and it works as expected.
I did find an existing bug while testing which was fixed in 3438535.
Before
After
The bug only occurred when switching between fiat and altcoin payment accounts in the create offer dialog.
|
@milesap Congrats to your first merged PR! Just a heads up that we changed recently our process on what kind of contribution is up for compensation and which is not. |
Add a new method to DisplayUtils to restore the old rounding behaviour of formatVolumeWithCode whenever a fractional volume is required. This fixes a regression caused by bisq-network#3926 to remove unnecessarily displayed decimals for fiat volumes - it appears that in every case but the avg. dollar price on the BSQ dashboard a whole number should be shown. Also add a relevant test.
Add a new method to DisplayUtils to restore the old rounding behaviour of formatVolumeWithCode whenever a fractional volume is required. This fixes a regression caused by #3926 to remove unnecessarily displayed decimals for fiat volumes - it appears that in every case but the avg. dollar price on the BSQ dashboard a whole number should be shown. Also add a relevant test.
Fixes #3449
Reduce number of decimals shown from 4 to 2 for fiat monetary values.