Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify seednode install script to use GitHub API for latest release tag #3853

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Modify seednode install script to use GitHub API for latest release tag #3853

merged 1 commit into from
Jan 5, 2020

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Jan 3, 2020

Replace hard-coded tag in seednode installer script with a GitHub API call to get latest release tag

@wiz wiz requested a review from ripcurlx as a code owner January 3, 2020 19:57
@wiz wiz force-pushed the seednode-installer-github-api branch from 03bb367 to 018a9fe Compare January 4, 2020 09:31
devinbileck
devinbileck approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

sqrrm
sqrrm approved these changes Jan 5, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

We have to be aware that we might not always want to upgrade to the latest bitcoind if there are features removed that we need.

@sqrrm sqrrm merged commit 6a9c0c8 into bisq-network:master Jan 5, 2020
@wiz wiz deleted the seednode-installer-github-api branch January 5, 2020 13:46
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 7, 2020
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
Closed
@wiz wiz mentioned this pull request Jan 14, 2020
Closed
@devinbileck devinbileck mentioned this pull request Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

@devinbileck devinbileck devinbileck approved these changes

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@wiz @devinbileck @sqrrm @ripcurlx