Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc comment warnings in TradeWalletService & OfferUtil #3812

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

stejbac
Copy link
Contributor

@stejbac stejbac commented Dec 19, 2019

Add missing @param, @return and @throws tags and improve formatting. Fix some missing/incorrect method descriptions, as well.

(Also add some missing @Nullable method parameter annotations and remove a redundant throws VerificationException clause.)

Add missing @param, @return and @throws tags and improve formatting.

(Also add some missing @nullable method parameter annotations.)
@stejbac stejbac requested a review from ripcurlx as a code owner December 19, 2019 16:38
@ripcurlx
Copy link
Contributor

Just a heads up that I haven't planed to be available until 2nd of Jan, but I'll still try to do some reviews tomorrow.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit 4e905e8 into bisq-network:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants