Remove unused method parameters #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude abstract or default methods, as well as cases where the parameter is currently unused but is probably intended to be used later.
Use 'clock.millis()' instead of "new Date().getTime()" in SignedWitness & AccountAgeWitness, as the latter may have been left as an oversight. Also tidy the date field of the toString() methods.
Also fix forwarding of telescoping method parameters in FormBuilder and FormattingUtils.
ripcurlx
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
ACK
Tested a quick trade with signed accounts on Regtest.
@stejbac Just a heads up, that we are planning to not compensate pure refactoring PRs in the future to push the focus more on direct user value. Refactorings are perfectly fine and do have value of course, but we'd like to see them within some other work that has direct user value like in your last PR.
|
OK, that's fine. I did have one other non-functional PR prepared (that shouldn't really need testing as it only involves doc comments). After that, I plan to submit some more (non-DAO-related) performance enhancements I've been working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused parameters from assorted methods (as found by the IDE), excluding abstract or default methods, as well as cases where the parameter is currently unused but is probably intended to be used later.
For most other such methods, either suppress the warning (where the parameter looks like it will be needed later) or actually use the parameter where it probably should have been. The latter applies to a couple of forwarded telescoping method parameters and an injected clock parameter added a few months ago to
[Signed|AccountAge]Witness.isDateInTolerance.