Fix double presence of the word "days" #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ripcurlx
suggested changes
Dec 19, 2019
There was a problem hiding this comment.
utACK on the code changes. Removing it from the translations file is the right thing to do in that case.
NACK - as you need to sign your commits https://help.github.com/en/github/authenticating-to-github/signing-commits
ripcurlx
approved these changes
Dec 19, 2019
|
My first merged PR, so happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Alice tries to takes an offer that can't take, she receives the following message:
As you can see, there is a double occurrence of the word "days". This PR should fix that as shown below.
I thought it was easier to change the string in the properties file, if you think it is better to change in the Java code instead, let me know.