Fix failing test when there are spaces in the project path #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stejbac You have to sign your commits: https://help.github.com/en/github/authenticating-to-github/signing-commits |
Use URI.getPath() rather than URL.getFile() to get the absolute path of a test resource, since the latter fails to perform URL decoding. This breaks the tests when the project root contain chars needing %-encoding.
stejbac
force-pushed
the
support-spaces-in-project-path
branch
from
11860c5 to
e20f841
Compare
|
I've now added a GPG key to Github and amended the commit to include a signature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use URI.getPath() rather than URL.getFile() to get the absolute path of a test resource, since the latter fails to perform URL decoding. This breaks the tests when the project root contain chars needing %-encoding.
This fixes errors of the following form in (BisqInstallerTest) verifySignature: