Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2.0] Only show warning for risky payment menthods #3497

Merged
merged 1 commit into from
Oct 28, 2019
Merged

[1.2.0] Only show warning for risky payment menthods #3497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion core/src/main/resources/i18n/displayStrings.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2890,7 +2890,21 @@ payment.halCash.info=When using HalCash the BTC buyer needs to send the BTC sell
UI in the create-offer and take-offer screen will adjust the BTC amount so that the EUR amount is correct. You cannot use market \
based price as the EUR amount would be changing with changing prices.\n\n\
In case of a dispute the BTC buyer needs to provide the proof that they sent the EUR.
payment.limits.info=To limit chargeback risk, Bisq sets per-trade buy limits based on the following 2 factors:\n\
payment.limits.info=Please be aware that all bank transfers carry a certain amount of chargeback risk.\n\
\n\
To mitigate this risk, Bisq sets per-trade limits based on two factors:\n\
\n\
1. The estimated level of chargeback risk for the payment method used\n\
2. The age of your account for that payment method\n\
\n\
The account you are creating now is new and its age is zero. As your account grows in age over a two-month period, your per-trade limits will grow along with it:\n\
\n\
● During the 1st month, your per-trade limit will be {0}\n\
● During the 2nd month, your per-trade limit will be {1}\n\
● After the 2nd month, your per-trade limit will be {2}\n\
\n\
Please note that there are no limits on the total number of times you can trade.
payment.limits.info.withSigning=To limit chargeback risk, Bisq sets per-trade buy limits based on the following 2 factors:\n\
\n\
1. General chargeback risk for the payment method\n\
2. Account signing status\n\
Expand Down
13 changes: 11 additions & 2 deletions desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,17 @@ private void onSaveNewAccount(PaymentAccount paymentAccount) {
.onAction(() -> doSaveNewAccount(paymentAccount))
.show();
} else {
new Popup<>().information(Res.get("payment.limits.info",
formatter.formatCoinWithCode(OfferRestrictions.TOLERATED_SMALL_TRADE_AMOUNT),

String limitsInfoKey = "payment.limits.info";
String initialLimit = formatter.formatCoinWithCode(maxTradeLimitFirstMonth);

if (PaymentMethod.hasChargebackRisk(paymentAccount.getPaymentMethod(), paymentAccount.getTradeCurrencies())) {
limitsInfoKey = "payment.limits.info.withSigning";
initialLimit = formatter.formatCoinWithCode(OfferRestrictions.TOLERATED_SMALL_TRADE_AMOUNT);
}

new Popup<>().information(Res.get(limitsInfoKey,
initialLimit,
formatter.formatCoinWithCode(maxTradeLimitSecondMonth),
formatter.formatCoinWithCode(maxTradeLimitAsCoin)))
.width(700)
Expand Down