Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show BSQ trade fee in % per day #3357

Closed
wants to merge 4 commits into from
Closed

Show BSQ trade fee in % per day #3357

wants to merge 4 commits into from

Conversation

niyid
Copy link
Contributor

@niyid niyid commented Oct 3, 2019 •
edited
Loading

fixes #3292
fixes #3303

@niyid niyid requested review from ripcurlx and sqrrm as code owners October 3, 2019 07:32
@freimair
Copy link
Contributor

freimair commented Nov 1, 2019

just a note for the future: would you please use the official keywords for closing issues https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords? Thanks!

@niyid
Copy link
Contributor Author

niyid commented Nov 1, 2019

just a note for the future: would you please use the official keywords for closing issues https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords? Thanks!

Noted with thanks.

freimair
freimair suggested changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. except for the formatting issues. Please resolve them and then we can get this PR merged.

desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsViewModel.java Outdated Show resolved Hide resolved
@niyid niyid requested a review from freimair November 9, 2019 18:07
@niyid
Copy link
Contributor Author

niyid commented Nov 11, 2019 •
edited
Loading

@freimair

Curious why the PR is not automatically merged as advised here even after making the changes:

Merging is blocked

Merging can be performed automatically once the requested changes are addressed.

@ripcurlx
Copy link
Contributor

@freimair

Curious why the PR is not automatically merged as advised here:

###Merging is blocked
Merging can be performed automatically once the requested changes are addressed.

The reviewer has to accept the requested changes, otherwise anything could be added and automatically merged to master without an additional review.

@niyid
Copy link
Contributor Author

niyid commented Nov 11, 2019

@freimair
Curious why the PR is not automatically merged as advised here:

###Merging is blocked
Merging can be performed automatically once the requested changes are addressed.

The reviewer has to accept the requested changes, otherwise anything could be added and automatically merged to master without an additional review.

Ah. I see. Thanks for the clarification. I thought maybe the message means the reviewer had put in some condition to check for merge automation.

freimair
freimair approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@freimair freimair mentioned this pull request Nov 11, 2019
Closed
@ripcurlx
Copy link
Contributor

@niyid This PR contains unsigned commits.

ripcurlx
ripcurlx suggested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Based on my comment here: #3292 (comment)

@stale
Copy link

stale bot commented Dec 12, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Dec 12, 2019
@stale
Copy link

stale bot commented Dec 19, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this Dec 19, 2019
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx requested changes

@freimair freimair freimair approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
waiting for author was:dropped
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Provide a way to show burned BSQ in a specific timeframe Show BSQ trade fee in % per day
3 participants
@niyid @freimair @ripcurlx