Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show only active roles in "Bonded Roles" table #3320

Closed
wants to merge 1 commit into from
Closed

Show only active roles in "Bonded Roles" table #3320

wants to merge 1 commit into from

Conversation

ben-kaufman
Copy link
Contributor

Fix #3271.
Filter the bonded roles list to contain only active bonds in the RolesView table.

@ben-kaufman
Show only active roles in "Bonded Roles" table
6e5d78b 
Fix bisq-network#3271.
Filter the bonded roles list to contain only active bonds in the RolesView table.
chimp1984
chimp1984 approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wiz
Copy link
Contributor

wiz commented Sep 25, 2019

I don’t think this is the correct fix, because the table needs to show inactive bonds that have been approved but not yet posted.

sqrrm
sqrrm requested changes Sep 25, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

As @wiz says, this will filter out all non committed bonds. What needs to be done is to filter out failed proposals to take on a bonded role but still show those role proposals that have been accepted by the DAO but not yet locked up their funds in a bond.

@chimp1984
Copy link
Contributor

I don’t think this is the correct fix, because the table needs to show inactive bonds that have been approved but not yet posted.

Yes you are right! Sorry for the too quick utACK! Good to have more eyes on that!

NACK

@ripcurlx
Copy link
Contributor

@ben-kaufman Are you up for making the required changes? See comments above ^^

chimp1984 added a commit to chimp1984/bisq that referenced this pull request Nov 24, 2019
@chimp1984
Only show accepted bonded roles in bond view.
ff10f7c 
Fixes bisq-network#3271

Replaces bisq-network#3320
@chimp1984 chimp1984 mentioned this pull request Nov 24, 2019
Merged
@chimp1984
Copy link
Contributor

Replaced by #3676

This PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm requested changes

@chimp1984 chimp1984 chimp1984 approved these changes

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rejected role is shows in bonded roles
5 participants
@ben-kaufman @wiz @chimp1984 @ripcurlx @sqrrm