Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mediation ui #3254

Merged
merged 6 commits into from
Sep 13, 2019
Merged

Improve mediation ui #3254

merged 6 commits into from
Sep 13, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx requested a review from sqrrm as a code owner September 13, 2019 11:58
@ripcurlx
Copy link
Contributor Author

@chimp1984 I've adapted your code to address these issues.

sqrrm
sqrrm requested changes Sep 13, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix spelling mistake, otherwise good

core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
chimp1984
chimp1984 approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx
Copy link
Contributor Author

Please fix spelling mistake, otherwise good

Thanks for spotting the typo. Just pushed the change.

@ripcurlx ripcurlx merged commit 12809a3 into bisq-network:release/v1.1.6 Sep 13, 2019
@ripcurlx ripcurlx deleted the improve-mediation-ui branch September 26, 2019 12:11
@ripcurlx ripcurlx mentioned this pull request Oct 7, 2019
Closed
@sqrrm sqrrm mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm requested changes

@chimp1984 chimp1984 chimp1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ripcurlx @sqrrm @chimp1984