Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert DAO changes to add bonded role for Analytics Operator #3241

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Sep 11, 2019

We decided to revert this, per discussion in bisq-network/proposals#115

@wiz wiz requested a review from ripcurlx as a code owner September 11, 2019 07:39
@wiz wiz changed the title Revert dao changes Revert DAO changes to add bonded role for Analytics Operator Sep 11, 2019
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - As mentioned by DAO devs it might work, but it is too much risk to do so without in-depth testing.

@ripcurlx ripcurlx merged commit fc72225 into bisq-network:master Sep 11, 2019
@wiz wiz deleted the revert-dao-changes branch September 11, 2019 08:21
@chimp1984
Copy link
Contributor

chimp1984 commented Sep 11, 2019

@wiz @ripcurlx Thanks!

I was thinking more about the possible consquences and I am now pretty sure that it would have had serious issues. I try to explain (not 100% sure without going through the code and testing but 99% sure).

If a bonded role request would have been done, not updated users would have been out of sync (diff. proposal hash, their vote would be invalid). If not more then 80% of voters (80% by stake) would have either updated or not updated the whole voting cycle would have been invalid. We require that a super majority (> 80%) of voters have the same p2p network data (by hash) on which voting is based on.

So you see tiny trivial seeming changes can have severe consequences in the DAO.

If we need to add a field we need to announce it early enough so DAO stakeholders have time to update. We can enforce it by Filter.disableDaoBelowVersion so not updated users cannot partizipate in governance activities in the DAO. So it it is well planned we are able to do small changes but also those would require very careful thoughts and testing and contain some risks.

While Betanet testing we had such a case (caused by other reasons) where we did not reach 80% and voting round failed. This was also due unexpected reasons and it took a while to find out why it happened (so far to risks even if you are sure all will go fine).

We have to consider the DAO as set in stone and changes in concensus need to justify the risk and should be considered exceptional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants