Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bsq price trend indicator #3226

Merged
merged 6 commits into from
Sep 9, 2019
Merged

Add bsq price trend indicator #3226

merged 6 commits into from
Sep 9, 2019

Conversation

chimp1984
Copy link
Contributor

No description provided.

@chimp1984
Change text field for median to average 30
c3009c8 
The average 30 days price is more relevant information than the small
different between average and median price. To add a second tuple of
both would be another option would overload the screen with not that
relevant information.

In a follow up commit we want to add an ip/down indication so see
price trend.

Fixes also handling of 0 values.
@chimp1984
Apply reformat (no code change)
d2877d2
@chimp1984
Add support for columnIndex
fb15464
@chimp1984
Add price trend indicator
4278366 
If average 30 days price is > av. 90 days price we show a green
arrow up, otherwise a red arrow down. If same we don't show an arrow.
@chimp1984
Copy link
Contributor Author

The median price is not based on amount weight, so the average is considered more exact IMO.
This PR replaces the median 90 day price wioth the average 30 days and adds an indicator if price is going up or down.

Screen Shot 2019-09-08 at 12 02 18

Screen Shot 2019-09-08 at 12 03 48

@chimp1984
Fix dev test change
b3310f5 
Forgot to change back a small change to test directions...
@chimp1984 chimp1984 mentioned this pull request Sep 8, 2019
Closed
sqrrm
sqrrm approved these changes Sep 8, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

The median is now gone, perhaps it would've been nice to keep it, but I have no real strong opinion there.

@chimp1984
Copy link
Contributor Author

perhaps it would've been nice to keep it, but I have no real strong opinion there.

I was alos wondering to make 2 lines, but I think its not worth it. Too much info weakens the important info.

@wiz
Copy link
Contributor

wiz commented Sep 9, 2019

It's backwards, should be BTC/BSQ

Screen Shot 2019-09-09 at 10 38 18

@sqrrm sqrrm mentioned this pull request Sep 9, 2019
Closed
ripcurlx
ripcurlx approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit bb806cf into bisq-network:release/v1.1.6 Sep 9, 2019
@chimp1984 chimp1984 deleted the add-bsq-price-trend-indicator branch September 10, 2019 08:21
@chimp1984
Copy link
Contributor Author

It's backwards, should be BTC/BSQ

No altcoins are displayed with Altcoin/BTC - not logical but the standard...

@ripcurlx ripcurlx mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chimp1984 @wiz @ripcurlx @sqrrm