Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old capability requirements #3215

Conversation

chimp1984
Copy link
Contributor

We leave the DAO related capabilities as it might be useful in future for flexibility if there is a use case for a non-DAO node.

We do not have any old versions anymore which might not support
AckMessages, so we can remove it. It might also fix issues that
AckMessages are not sent as the capabilities are not known yet.
We do not have any old versions anymore which might not support
AccountAgeWitness, so we can remove it.
We do not have any old versions anymore which might not support
TradeStatistics2, so we can remove it.
@chimp1984 chimp1984 requested a review from ripcurlx as a code owner September 6, 2019 10:20
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 0a263b0 into bisq-network:release/v1.1.6 Sep 6, 2019
@chimp1984 chimp1984 deleted the remove-old-capability-requirements branch September 6, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants