Remove PGP keys from the KeyRing #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PGP support was envisioned in the KeyRing but never fully implemented. This removes the (essentially) dead code. The protobuf message compatibility is implemented with `reserved`.
|
Looks good to me, but I'd like to have an ACK by @freimair, @sqrrm or @ManfredKarrer before merging. |
|
utAck removing dead code is great. I was just doing a deep dive into this code yesterday and also thought this should simply be removed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PGP support was envisioned in the KeyRing but never fully implemented. This removes the (essentially) dead code.
This code impeded my understanding on how we use signatures. My initial impression was that we use PGP for p2p message signing, which is not the case.
The protobuf message compatibility is implemented with
reserved.