Improve logging #3178
Merged
Improve logging #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add better logs and duration measurements for expensive operations - Convert debug logs to trace to avoid flooding the output in debug log mode. - Cleanups
- Remove processDelayedItems list as we do not delay anymore the data items and protectedStoragePayloads do not get an extra treatment if they are marked as LazyProcessedPayload. - Add duration logging - Replace checkArgument with an if check - Apply code inspection - Cleanup
Creating the daoStateHash is quite expensive (about 20-30 ms/block). As this happens while parsing it delays the parsing time (parsing is very fast). We persist t the hashes so it is only done for new blocks. For 1 month of blocks (4000) it would take about 80-120 seconds. It is not blocking the user thread as it is done per block and those are parsed one after another.
sqrrm
approved these changes
Sep 1, 2019
core/src/main/java/bisq/core/dao/monitoring/DaoStateMonitoringService.java
Outdated
Show resolved
Hide resolved
…Service.java Co-Authored-By: sqrrm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help for debugging to enable to use debug level without getting the output filled up completely. Also adds some duration measurements to help to spot performance bottlenecks.
We should add those duration logs at each method which is suspect to be expensive.