Validate phone numbers #3134
Closed
Validate phone numbers #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/util/validation/CountryCallingCodes.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
desktop/src/test/java/bisq/desktop/util/validation/PhoneNumberValidatorTest.java
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
ghubstan
force-pushed
the
validate-phone
branch
2 times, most recently
from
e452fe8 to
2c7a948
Compare
ghubstan
force-pushed
the
validate-phone
branch
2 times, most recently
from
5573b9f to
1ea6cb8
Compare
Created new PhoneNumberValidator + Test. Validator hides no arg constructor; public constructor requires two letter ISO country code for validating inputs. After successful validation, inputs are transformed into E.164 format and cached in a field, accessible via a getter method. However, area and region codes are not checked for correctness. End users are responsible for correctness of area/region codes. Four i18n properties (validation.phone.*) were added to displayStrings.properties This is a partial fix for Issue bisq-network#3042. The validator will be integrated into the GUI if PR is approved & patch is merged. Question for Bisq devs: Another new pkg protected class, CountryCallingCodes, contains an immutable map of ISO country codes -> country calling codes; it is the only non-validator class in its package. The map declaration is too large to live in the PhoneNumberValidator class, even after tweaking idea.properties in an attempt to prevent the IDE from freezing. Is it OK to leave CountryCallingCodes where it is, or is there a more appropriate home for it?
ghubstan
force-pushed
the
validate-phone
branch
from
2520cbe to
447556b
Compare
ripcurlx
suggested changes
Aug 27, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new PhoneNumberValidator + Test. Validator hides
no arg constructor; public constructor requires two letter
ISO country code for validating inputs.
After successful validation, inputs are transformed into E.164
format and cached in a field, accessible via a getter method.
However, area and region codes are not checked for correctness.
End users are responsible for correctness of area/region codes.
Four i18n properties (validation.phone.*) were added to
displayStrings.properties
This is a partial fix for Issue #3042. The validator
will be integrated into the GUI if PR is approved & patch is
merged.
Question for Bisq devs:
Another new pkg protected class, CountryCallingCodes, contains
an immutable map of ISO country codes -> country calling codes;
it is the only non-validator class in its package. The map
declaration is too large to live in the PhoneNumberValidator class,
even after tweaking idea.properties in an attempt to prevent
the IDE from freezing. Is it OK to leave CountryCallingCodes
where it is, or is there a more appropriate home for it?